SplObjectStorage iterates over objects#4789
Conversation
|
I don't get it, why shouldn't it be cached? |
|
ClassReflection created via 
while the one created via 
so by caching the |
|
Hmm no. This doesn't make sense. Will have another look tomorrow |
|
had another look but still I am not yet sure about the causation. the difference between caching and not caching is, that
|
staabm
force-pushed
the
bug13985
branch
2 times, most recently
from
ed70201 to
ecd7985
Compare
staabm
force-pushed
the
bug13985
branch
2 times, most recently
from
d3d5255 to
e710e76
Compare
cs278
left a comment
cs278
left a comment
There was a problem hiding this comment.
Tested - fixes phpstan/phpstan#14046 for me
src/Type/ObjectType.php
Outdated
| @@ -1746,7 +1746,7 @@ public function getClassReflection(): ?ClassReflection | |||
|
|
|||
| $classReflection = $reflectionProvider->getClass($this->className); | |||
There was a problem hiding this comment.
Should we still cache the classReflection before the withType call ?
Maybe the code could be
if ($this->classReflection === null) {
$reflectionProvider = ReflectionProviderStaticAccessor::getInstance();
if (!$reflectionProvider->hasClass($this->className)) {
return null;
}
$this->classReflection = $reflectionProvider->getClass($this->className);
}
if ($this->classReflection->isGeneric()) {
return $this->classReflection->withTypes(array_values($classReflection->getTemplateTypeMap()->map(static fn (): Type => new ErrorType())->getTypes()));
}
return $this->classReflection;
There was a problem hiding this comment.
good point. I think your suggestions makes the intent clearer.
4 participants
closes phpstan/phpstan#13985
closes phpstan/phpstan#14046
partly reverts #4761